Skip to content

Add product: Show celebratory view when the first product is created #9790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
May 23, 2023
Merged

Add product: Show celebratory view when the first product is created #9790

merged 17 commits into from
May 23, 2023

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented May 22, 2023 •
edited
Loading

Part of #9785

Description

This PR adds a new view to celebrate when a product is created for the first time. This view contains a button to share the new product too. To make it more fun, the view also has confetti when first presented - this is handled by a new library.

The AddProductCoordinator was updated with a new param isFirstProduct, used to decide whether to show the celebratory view after a product is successfully created.

The coordinator is updated in two places to ensure that we celebrate the first product from store onboarding and the empty view of the Products tab.

Testing instructions

  • Make sure that you have access to a store with the checklist for creating the first product not done yet.
  • Tap the onboarding item to create the first product for the store and publish the product from the product form.
  • After the product is published or saved as draft, you should see that a new view is presented to celebrate the new product. In Xcode console, notice Tracks event: first_created_product_shown.
  • Tap "Share Product", a share sheet should be presented with the correct product URL. In Xcode console, notice Tracks event: first_created_product_share_tapped.
  • Navigate to the Products tab and remove the newly created product. The empty view should then be displayed.
  • Tap "Add Product" to create a new product. When the product is published or saved as draft, the celebratory screen should be presented again.

Screenshots

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-05-22.at.16.43.26.mp4
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added type: task An internally driven task. feature: add/edit products Related to adding or editing products. labels May 22, 2023
@itsmeichigo itsmeichigo added this to the 13.8 milestone May 22, 2023
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented May 22, 2023 •
edited
Loading

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr9790-be7f1ea on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@itsmeichigo itsmeichigo marked this pull request as ready for review May 22, 2023 09:49
@itsmeichigo itsmeichigo mentioned this pull request May 22, 2023
Closed
9 tasks
@selanthiraiyan selanthiraiyan self-assigned this May 22, 2023
selanthiraiyan
selanthiraiyan approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@selanthiraiyan selanthiraiyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected and the confetti looks nice. 🎉

I left a few non-blocking nits/questions.

🚢

WooCommerce/Classes/ViewRelated/Products/Add Product/FirstProductCreatedView.swift Outdated

private extension FirstProductCreatedHostingController {
enum Localization {
static let cancel = NSLocalizedString("Cancel", comment: "Button to dismiss the first created product screen")
Copy link
Contributor

@selanthiraiyan selanthiraiyan May 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nit: IMO, "Cancel" might make it challenging to understand whether sharing will be cancelled by tapping this button. (After initiating share) WDYT about using "Close"?

Copy link
Contributor Author

@itsmeichigo itsmeichigo May 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the button title to "Dismiss" in 022a58f 👍

WooCommerce/Classes/ViewRelated/Products/Add Product/FirstProductCreatedView.swift
super.init(rootView: FirstProductCreatedView())
rootView.onSharingProduct = { [weak self] in
guard let self else { return }
SharingHelper.shareURL(url: productURL, from: self.view, in: self)
Copy link
Contributor

@selanthiraiyan selanthiraiyan May 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Is it possible to pass onCompletion block to SharingHelper and dismiss this screen from it?

Copy link
Contributor Author

@itsmeichigo itsmeichigo May 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't get a callback when the user submitted any content in the share sheet, so it's not technically possible to handle onCompletion.

Copy link
Contributor

@selanthiraiyan selanthiraiyan May 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, OK. I thought we could use theonCompletion parameter. https://github.com/woocommerce/woocommerce-ios/blob/trunk/WooCommerce/Classes/Tools/SharingHelper.swift#L29

@peril-woocommerce
Copy link

peril-woocommerce bot commented May 23, 2023

Messages
📖

This PR contains changes to Tracks-related logic. Please ensure the following are completed:
PR Author

  • The PR must be assigned the Tracks label
    PR Reviewer
  • The tracks events must be validated in the Tracks system.
  • Verify the internal tracks spreadsheet has also been updated.

Generated by 🚫 dangerJS

@itsmeichigo itsmeichigo enabled auto-merge May 23, 2023 01:33
@itsmeichigo itsmeichigo merged commit f166b90 into trunk May 23, 2023
@itsmeichigo itsmeichigo deleted the feat/9785-celebrate-first-product branch May 23, 2023 02:00
hafizrahman added a commit to woocommerce/woocommerce-android that referenced this pull request Jun 7, 2023
@hafizrahman
Add: Tracking for when dialog is shown and share is tapped.
7fcdb39 
This is to match analytics added in iOS:

woocommerce/woocommerce-ios#9790
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaclync jaclync Awaiting requested review from jaclync

1 more reviewer

@selanthiraiyan selanthiraiyan selanthiraiyan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@selanthiraiyan selanthiraiyan

Labels

feature: add/edit products Related to adding or editing products. type: task An internally driven task.

Projects

None yet

Milestone

13.8

Development

Successfully merging this pull request may close these issues.

4 participants

@itsmeichigo @wpmobilebot @selanthiraiyan